Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readConfigFromDisk should ignore package.json entries #2472

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Aug 14, 2024

Summary:

I was trying out 0.75 and not sure why is worked before, but now the config command returned this value - literally "src/index", instead of the value influenced by the config file.

Test Plan:

npx react-native config returned a valid result in the repo

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee
Copy link
Member

@szymonrybczak mind looking at it? I'm not sure why we haven't used searchPlaces param for reading from disk.

@vonovak
Copy link
Member Author

vonovak commented Aug 20, 2024

It was there before, but was removed with https://github.com/react-native-community/cli/pull/2343/files
Looks like a mistake to me?

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@szymonrybczak szymonrybczak merged commit 07e9f44 into main Aug 23, 2024
4 of 10 checks passed
@szymonrybczak szymonrybczak deleted the @vonovak/patch-1 branch August 23, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants