Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make "install CocoaPods" step in init true by default #527

Merged
merged 2 commits into from
Jul 14, 2019

Conversation

swyxio
Copy link
Contributor

@swyxio swyxio commented Jul 12, 2019

fix minor bug where shouldInstallCocoaPods is falsy by default

Summary:

when i run this cli for the first time with no cocoapods, the prompt asks me to install with a "Y/n" but when i hit enter it is taken as falsy and so it shows "No". but then it goes on to install anyway. seems like a weird quirk with inquirer

image

Test Plan:

image

fix minor bug where shouldInstallCocoaPods is falsy by default
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
@thymikee thymikee changed the title fix minor bug where shouldInstallCocoaPods is falsy by default fix: make "install CocoaPods" step in init true by default Jul 14, 2019
@thymikee thymikee merged commit c386351 into react-native-community:master Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants