Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reload button in debugger UI #611

Merged

Conversation

thecodrr
Copy link
Contributor

@thecodrr thecodrr commented Aug 4, 2019

Summary:

This acts as a useful extension of reload endpoint implemented in #574.

Side note: Maybe we can rename the button to something more descriptive than 'Reload' as that can be a little confusing...? Suggestions welcome

Test Plan:

I tested the endpoint directly in Chrome DevTools and by deploying a sample app using run-android and using the button to reload. It works.

cc @thymikee

@thymikee thymikee merged commit 7d3fa1e into react-native-community:master Aug 8, 2019
@thecodrr thecodrr deleted the reload-button-in-debugger-ui branch August 8, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants