feat: fallback to default browser if Chrome is not found #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
changed the title
thymikee
reviewed
Aug 4, 2019
packages/cli/src/commands/server/middleware/getDevToolsMiddleware.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
grabbou
reviewed
Aug 7, 2019
| 'https://www.google.com/chrome/', | ||
| )}`, | ||
| ); | ||
| //fallback to default browser |
There was a problem hiding this comment.
nit: space here before the inline command. I also think we can rid of that comment and rename the function to something like: launchDefaultBrowser
thymikee
pushed a commit
that referenced
this pull request
Aug 15, 2019
* feat: fallback to default browser if chrome not found * refactor: make flow happy * refactor: fix launchDebugger path Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> * refactor: rename launchBrowser to launchDefaultBrowser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It can be annoying for users (like me) who do not have Google Chrome installed to enable 'Remote Debugging' only to receive an error. This rectifies that by falling back to the default installed browser making the whole experience more fluid.
Test Plan:
Tested on a sample app by enabling 'Remote Debugging'.