[iOS][auto-linking] fix: Add missing scriptPhases config #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails otherwise with an `invalid args` error. Additionally adds a log that a custom script was added for the Pod.
Ignore the previous commit which was using `symbolize_keys!` - doh
Salakar
changed the title
thymikee
approved these changes
Aug 6, 2019
| @@ -52,6 +52,7 @@ export const dependencyConfig = t | |||
| podspecPath: t.string(), | |||
| sharedLibraries: t.array().items(t.string()), | |||
| libraryFolder: t.string(), | |||
| scriptPhases: t.array().items(t.object()), | |||
There was a problem hiding this comment.
we could be a bit more specific there to help users avoid typos
Salakar
commented
Aug 6, 2019
orta
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes the
scriptPhasesconfig support that was partially implemented as part of the first version of auto linking for iOS.Test Plan:
Locally linked and tested using React Native Firebase custom script phases.
Will post screenshots tomorrow, it's late here 😴Custom script phase config used for testing:
Logging showing custom script phase was added:
Custom script phase is shown in the generated workspace:
