New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix launching chrome dev tools #63

Merged

grabbou merged 1 commit into react-native-community:master from janicduplessis:patch-1

Jan 8, 2019

Contributor

janicduplessis commented Jan 8, 2019

We didn't pass the port to the middleware manager which is needed by the getDevToolsMiddleware to launch chrome dev tools.


          Fix launching chrome dev tools

04447a4

grabbou approved these changes

View reviewed changes

grabbou merged commit 6de63fe into react-native-community:master

Member

grabbou commented Jan 8, 2019

Awesome @janicduplessis, thank you for this PR! Just in time for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet