Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copyProjectTemplateAndReplace.js #631

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Update copyProjectTemplateAndReplace.js #631

merged 1 commit into from
Aug 15, 2019

Conversation

pvinis
Copy link
Member

@pvinis pvinis commented Aug 13, 2019 •
edited
Loading

Summary:

Quick fix for the _prettierrc.js file. We should probably fix it with a proper lookup of all files in depth 0 starting with _.

Test Plan:

thymikee
thymikee approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thymikee
Copy link
Member

Can you update the e2e test as well?

@thymikee thymikee merged commit 0ea4315 into master Aug 15, 2019
@thymikee thymikee deleted the pvinis-patch-1 branch August 15, 2019 09:01
thymikee pushed a commit that referenced this pull request Aug 15, 2019
@pvinis @thymikee
fix: copy .prettierrc from legacy init template (#631)
0694c3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasbento lucasbento lucasbento approved these changes

@thymikee thymikee thymikee approved these changes

@Esemesek Esemesek Awaiting requested review from Esemesek

@grabbou grabbou Awaiting requested review from grabbou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvinis @thymikee @lucasbento