-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: Make package name a required argument in link #64
Conversation
What about linking assets like fonts? Is this still supported somehow? |
Yes, it is still supported. To be honest, I wonder if we should keep it. Linking only a single dependency but, at the same time, linking all the assets, looks to me like a really badly designed behaviour. I wonder whether we should:
|
Definitely linking assets is needed.
That's weird yes, unless the single dependency has assets. I think something explicit is better, just like: react-native link --assets |
Or linking assets (or whatever there is in the config file) would be performed when no name is passed. |
Problem with this is that it's an implicit breaking change. People running Since we are forcing the name, I guess the better approach is to require the name of the project itself or... create another command (probably unwanted). |
Make
packageName
required inlink
command.Fixes: #48