Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Delta Bundler from debugger UI. #640

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented Aug 19, 2019

Summary:

Just cleaning up some code, loading regular bundles is fine.

Test Plan:

Try out the debugger-ui, it works.

@cpojer
Copy link
Member Author

cpojer commented Aug 19, 2019

Would be nice if somebody could double check this in open source.

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what ever happened to delta bundles that they're not used anymore?

@cpojer
Copy link
Member Author

cpojer commented Aug 19, 2019

There is a lot of complexity involved with building native delta bundler clients across platforms. Now we have Fast Refresh (RN 0.61) which reduces the amount of times somebody will refresh (HMR is basically a variant of delta bundling) and at FB we are doing bundle splitting in development which reduced time spent in Metro by about 10x and also reduced memory usage on device by the same amount.

tl;dr: we believe reloads on the client are now fast enough not to need the extra complexity. The server parts of delta bundling within Metro will stay the same and are invaluable, of course.

@thymikee thymikee merged commit b88deca into react-native-community:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants