Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: add types to doctor #664

Merged
merged 4 commits into from
Sep 9, 2019
Merged

imp: add types to doctor #664

merged 4 commits into from
Sep 9, 2019

Conversation

thymikee
Copy link
Member

@thymikee thymikee commented Sep 3, 2019 •
edited
Loading

Summary:

  • add a generic HealthCheckInterface type
  • remove redundant getDiagnosticsAsync, make getDiagnostics async
  • fix type issues

Test Plan:

Flow passes

@thymikee thymikee changed the title WIP: doctor: add types doctor: add types Sep 9, 2019
@thymikee thymikee merged commit f942c1b into master Sep 9, 2019
@thymikee thymikee deleted the doctor/flow branch September 9, 2019 16:54
@Esemesek Esemesek changed the title doctor: add types imp: add types to doctor Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Esemesek Esemesek Esemesek approved these changes

@grabbou grabbou Awaiting requested review from grabbou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thymikee @Esemesek