Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate info command to TS #685

Merged
merged 1 commit into from
Sep 10, 2019
Merged

chore: migrate info command to TS #685

merged 1 commit into from
Sep 10, 2019

Conversation

FLGMwt
Copy link
Contributor

@FLGMwt FLGMwt commented Sep 9, 2019

Summary:

@thymikee I cribbed your ignore comments from #683. If this is the right approach, I'll claim a few more.

Test Plan:

Green CI

thymikee
thymikee requested changes Sep 9, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits to address, but almost there :)

packages/cli/src/commands/info/__tests__/info.test.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/info/info.ts Show resolved Hide resolved
packages/cli/src/commands/info/info.ts Outdated Show resolved Hide resolved
@thymikee
Copy link
Member

thymikee commented Sep 9, 2019

Let's wait for this PR #686 to be merged and then rebase

@thymikee
Copy link
Member

thymikee commented Sep 9, 2019

Merged, you can now rebae

@FLGMwt
Copy link
Contributor Author

FLGMwt commented Sep 9, 2019

I'll wait for #684 for src/index.js => src/index.ts to fix flow

@Esemesek
Copy link
Member

Esemesek commented Sep 9, 2019

@FLGMwt merged mentioned PR. You should be unblocked.

@FLGMwt FLGMwt force-pushed the typescriptify-info branch from 3b00599 to 863c7ea Compare September 9, 2019 22:01
@FLGMwt FLGMwt force-pushed the typescriptify-info branch from 863c7ea to 7ed3840 Compare September 9, 2019 22:08
@FLGMwt FLGMwt requested a review from thymikee September 9, 2019 22:12
@FLGMwt
Copy link
Contributor Author

FLGMwt commented Sep 9, 2019 •
edited
Loading

Any thoughts on the unrelated snapshot failure anyone? https://circleci.com/gh/react-native-community/cli/9083?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Seems fine locaclly for me.

    -       "pbxprojPath": "<<REPLACED>>/node_modules/react-native-test/ios/HelloWorld.xcodeproj/project.pbxproj",
    +       "pbxprojPath": "<<REPLACED>>/node_modules/react-native-test/customLocation/customProject.xcodeproj/project.pbxproj",

@FLGMwt FLGMwt mentioned this pull request Sep 10, 2019
Merged
@Esemesek
Copy link
Member

Everything passes locally for me. We'll just have to retrigger CircleCI.

Esemesek
Esemesek approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@Esemesek Esemesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job C:

@Esemesek Esemesek merged commit b49fe00 into react-native-community:master Sep 10, 2019
@FLGMwt FLGMwt deleted the typescriptify-info branch September 10, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Esemesek Esemesek Esemesek approved these changes

@grabbou grabbou Awaiting requested review from grabbou

@thymikee thymikee Awaiting requested review from thymikee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FLGMwt @thymikee @Esemesek