Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert findSymlinkedModules to TS #693

Merged
merged 3 commits into from
Sep 10, 2019
Merged

chore: convert findSymlinkedModules to TS #693

merged 3 commits into from
Sep 10, 2019

Conversation

pveyes
Copy link
Contributor

@pveyes pveyes commented Sep 10, 2019

Summary:

Part of #683.

Test Plan:

yarn flow-check && yarn test

@thymikee thymikee marked this pull request as ready for review September 10, 2019 08:14
@thymikee
Copy link
Member

There's still @flow strict and @format at the top of the file, can you remove these please?

@thymikee thymikee changed the title convert findSymlinkedModules to ts chore: convert findSymlinkedModules to TS Sep 10, 2019
@thymikee thymikee merged commit 3ff8ff3 into react-native-community:master Sep 10, 2019
@pveyes pveyes deleted the find-symlink-ts branch September 10, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@Esemesek Esemesek Awaiting requested review from Esemesek

@grabbou grabbou Awaiting requested review from grabbou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pveyes @thymikee