chore: migrated link command to TS

[anikethsaha]

Summary:

#683
Converted link command to Typescript
Also added preulink , postunlink to the cli-types in the config hooks

Test Plan:

• yarn test
• yarn lint

[FLGMwt]

Nice! I think this is one of the last of the commands. Just a few suggestions. 👐

[anikethsaha]

I am getting a good number of errors when adding the type package for inquirer.

FlagsType.platforms (in link and unlink) from Array<'ios' | 'android'> to Array<'ios' | 'android'>

A bit confused with this one. Where do I get those ios and android type !

Looks like this worked out: 2eaeb70

Will rebase it and try it

[assuncaocharles]

You can repro this w/ yarn build:ts. Looks like inquirer has a types package so you can do:

yarn workspace @react-native-community/cli add @types/inquirer

....

Yes, I think it's missing the @types/inquirer and after installing it some things should change. e.g:

import {prompt, QuestionCollection, Answers} from 'inquirer';

export default (questions: QuestionCollection) =>
  new Promise<Answers>((resolve, reject) => {
    if (!questions) {
      resolve({});
      return;
    }

    prompt(questions).then(resolve, reject);
  });

And to fix the

Module '"readline"' has no exported member 'Interface'.
1 import { Interface as ReadlineInterface, Key } from "readline";

Just run yarn add @types/node

[assuncaocharles]

...
PS:
I even got both node and inquirer in my node_modules
....

That's weird, I reproduced it locally and it worked well.. Try to run yarn add @types/inquirer @types/node from inside packages/cli/src/commands

[anikethsaha]

from packages/cli/src/commands or from packages/cli ? I guess from packages/cli/ right ?
I tried....no luck

[FLGMwt]

Can you push you branch to so we can take a look? You should have @types/node in your packages/cli/package.json .

As for the export changes from my branch, if you're having issues with rebasing the changes, just copy over the changes to your branch. There should be changes in the following files:

• packages/cli-types/src/index.ts
• packages/platform-android/src/link/warnAboutManuallyLinkedLibs.ts
• packages/platform-ios/src/link/warnAboutManuallyLinkedLibs.ts

[anikethsaha]

@FLGMwt @assuncaocharles I updated my fork, https://github.com/anikethsaha/cli/tree/migration/typescript-link-command
here it is!

[anikethsaha]

As for the export changes from my branch, if you're having issues with rebasing the changes, just copy over the changes to your branch. There should be changes in the following files:

I manually copy pasted it......IDK why the rebasing didnt work !

[FLGMwt]

I played around and I don't understand why, but adding an explicit version of @types/node made it work. I think it's something with how typescript resolved which type package to use for deps? It's probably the transitive @types/node@8 throwing things off but I have no idea. Give this a shot:

 yarn workspace @react-native-community/cli add @types/node@^12.7.5

Diff should look like:

[thymikee]

We use @types/node@8 in root config to make sure we use APIs that are compatible with the target we compile to. Does inquirer has issues with older typings as well? cc @Esemesek halp pls

[anikethsaha]

Does inquirer has issues with older typings as well?

I guess typescript is not able to resolve older versions.!

[FLGMwt]

We use @types/node@8 in root config to make sure we use APIs that are compatible with the target we compile to. Does inquirer has issues with older typings as well? cc @Esemesek halp pls

Ah, that makes sense, sorry for the confusion. Seems like it used to be called ReadLine instead of Interface: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/v8/base.d.ts#L1850.

Latest types have Interface re-exported as ReadLine so maybe @types/inquirer could use that instead? https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/readline.d.ts#L110

Unsure what to do in cli though other than mark as untyped to get this in.

[anikethsaha]

Should I downgrade the version then ?

[thymikee]

To unblock ourselves I'm fine with not typing inquirer. We can do this later

[anikethsaha]

Yeah this seems fine. I will remove typing for inquirer 👍

[thymikee]

LGTM 👍