Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert e2e init test and helpers to TS #705

Merged
merged 9 commits into from
Sep 11, 2019
Merged

chore: convert e2e init test and helpers to TS #705

merged 9 commits into from
Sep 11, 2019

Conversation

assuncaocharles
Copy link
Contributor

Hi,

Started to work on e2e test to migrate it to Typescript.

@assuncaocharles
Copy link
Contributor Author

Hey @thymikee

CI is not passing the e2e due to the snapshot not matching. Running yarn run test:ci:e2e -u don't quite work ( as expected I suppose )

Any suggestion about what to do here?

@thymikee
Copy link
Member

Running yarn run test:ci:e2e triggers Jest with --ci flag, which trumps -u. You could run yarn jest e2e -u, but I've done it for you :)

@thymikee thymikee changed the title chore: Convert e2e/init.test and jest/helpers to Typescript chore: convert e2e init test and helpers to TS Sep 11, 2019
@thymikee thymikee merged commit fde227d into react-native-community:master Sep 11, 2019
@thymikee
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants