Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no need from cd - on package.json so we can pass custom arguments #72

Merged

Conversation

ferrannp
Copy link
Member

No description provided.

@thymikee
Copy link
Member

This will change your working directory after running tests.
Time to setup Jest projects and run tests from the root ;)

@ferrannp
Copy link
Member Author

ferrannp commented Jan 10, 2019

@thymikee it doesn't locally. Isn't that the default behavior of npm:scripts ?

By the way this uncover the Flow errors that CircleCI was ignoring.

@thymikee
Copy link
Member

If it works, then cool, I'm not aware of such feature :D

@grabbou
Copy link
Member

grabbou commented Jan 10, 2019

@thymikee it depends. Each command on CircleCI runs in its own session, so it always starts from the "workingDirectory". If we have a separate "run" phase for "npm test", it should be good regardless of the "npm scripts" behaviour.

@grabbou
Copy link
Member

grabbou commented Jan 10, 2019

I am going to merge it and we should fix them.

@grabbou grabbou merged commit c5e3743 into react-native-community:master Jan 10, 2019
@ferrannp ferrannp deleted the fix/package-json-args branch January 10, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants