Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run instructions to use projectDir #736

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

raldred
Copy link
Contributor

@raldred raldred commented Sep 20, 2019

Summary:

Run instructions use projectName
Updated to use projectDir to display correct instruction when using the --direction option

Run instructions use projectName
Updated to use projectDir to display correct instruction when using the --direction option
@grabbou
Copy link
Member

grabbou commented Oct 1, 2019

That change looks good to me. I defer the final merge to @thymikee since I wasn't following the code changes in the past few weeks.

@thymikee
Copy link
Member

thymikee commented Oct 3, 2019

We intentionally displayed only the project name so the command is shorter, but now that we have --directory param it makes sense to display the whole path, even though it's uglier. Thanks!

@thymikee thymikee merged commit b9010e6 into react-native-community:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants