Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support
autolinking
in monorepos #768feat: support
autolinking
in monorepos #768Changes from 5 commits
b3b09ef
440f166
1ffc0c2
391505d
e0722c3
f85186f
435d314
78065e0
80be9d2
3495fe5
7e46d77
68639b7
f8de995
5041be8
53f59d1
9dd0ce1
3be7ea4
4091c4c
27fac31
0cbe32d
e362dc6
19fd10e
366b7c4
553df50
858ac79
883068f
7733cb2
c4c1745
a13e47f
bdcc9fa
07bd62e
858ea5e
94d8bba
81e7b10
beca41b
cc8c80c
6661421
781c0e6
46b0cd3
5033e50
cc4b5bf
7402931
90bacbc
d0bd034
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we don't have custom root, I think instead of using
project_root
we need to use cwd, because that's we look for – a relative path from cwd (ios dir) to our native module (in node_modules or custom path). This fixes the Slider repo example for me:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projet_root
isproject_root = Pathname.new(config["project"]["ios"]["sourceDir"])
few lines earlier - so that's exactly the location ofios
folder.PWD might be not a good idea, see: #657 when running from root folder with
--ios-directory
flag