Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rewrite main CLI entry point to TypeScript #787

Merged
merged 12 commits into from
Oct 14, 2019
Merged

chore: rewrite main CLI entry point to TypeScript #787

merged 12 commits into from
Oct 14, 2019

Conversation

grabbou
Copy link
Member

@grabbou grabbou commented Oct 14, 2019 •
edited
Loading

This pull requests converts main entry point of the CLI to use TypeScript.

@grabbou grabbou changed the title chore(typescript): rewrite cli entry chore: rewrite main CLI entry point to TypeScript Oct 14, 2019
grabbou
grabbou commented Oct 14, 2019
View reviewed changes
packages/cli/tsconfig.json Outdated Show resolved Hide resolved
thymikee
thymikee approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grabbou grabbou merged commit 507abc6 into master Oct 14, 2019
@grabbou
Copy link
Member Author

grabbou commented Oct 14, 2019

Thanks for late-night merge! One more PR and I can go to sleep! haha

@thymikee thymikee deleted the feat/rewrite-cli-entry branch October 14, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@Esemesek Esemesek Awaiting requested review from Esemesek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grabbou @thymikee