-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: Extract debugger-ui #832
Conversation
Thanks for sending this over @Esemesek and happy to see you back with PRs. Just wondering if you have applied the things we have discussed in the office already? I believe we have talked about extracting out the entire debugger middleware out to a separate package. |
EDIT: Discussed it offline, seems okay. |
Is this PR ready to ship / be reviewed? Also, shall we target |
import path from 'path'; | ||
|
||
export function debuggerUIMiddleware() { | ||
return serveStatic(path.join(__dirname, '..', 'ui')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: ../ui
is just fine, path
normalises for Windows by default.
Let's merge it to |
Summary:
Extract
debugger-ui
module out ofcli
.TODO:
html
file (extract styles, scripts and assets)Next steps:
Test Plan: