Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Carthage to excluded directories while finding .xcodeproj #839

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Add Carthage to excluded directories while finding .xcodeproj #839

merged 1 commit into from
Nov 7, 2019

Conversation

michalchudziak
Copy link
Contributor

Summary:

Added Carthage to excluded directories while finding .xcodeproj file.

Test Plan:

Add Carthage/test.xcodeproj to ios directory in example RN (61.4) project and run pod install and check if everything is alright.

thymikee
thymikee approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do for now, thank you very much!

@thymikee thymikee merged commit e703283 into react-native-community:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@Esemesek Esemesek Awaiting requested review from Esemesek

@grabbou grabbou Awaiting requested review from grabbou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalchudziak @thymikee