Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: deprecate link all behavior #85

Merged
merged 4 commits into from
Jan 15, 2019
Merged

Conversation

Esemesek
Copy link
Member

Deprecate react-native link without specifying packageName.

Tests:

  1. Init new project with react-native init $project_name
  2. Install a couple of native dependencies that need to be linked
  3. Invoke link command
node path/to/cli/packages/local-cli/cli.js link

screenshot 2019-01-12 at 13 26 24

Modules are linked correctly but we get deprecation notice.

@Esemesek Esemesek requested review from thymikee and grabbou January 12, 2019 12:32
Copy link
Member

@grabbou grabbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this feature! Just a small comment on the deprecation message itself and this is ready to go!

packages/local-cli/link/linkAll.js Outdated Show resolved Hide resolved
@grabbou
Copy link
Member

grabbou commented Jan 14, 2019

BTW - we really need a proper logger!

@grabbou
Copy link
Member

grabbou commented Jan 15, 2019

Fixed one thing and added URL to an issue where users will be able to let us know about the deprecation.

Copy link
Member

@grabbou grabbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the original PR. Waiting for @Esemesek to approve my changes that landed in the last commit and this is ready to go.

@Esemesek Esemesek merged commit 664fa66 into master Jan 15, 2019
@Esemesek Esemesek deleted the Esemesek/deprecate-link-all branch January 15, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants