Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary fix for a regression in monorepos #852

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

thymikee
Copy link
Member

@thymikee thymikee commented Nov 15, 2019

Summary:

Regression introduced in #824. Still looking for a better fix, because otherwise we'll need to reopen #793 and #804.

cc @mbios

Test Plan:

@patrickschmelter
Copy link

1799e44#commitcomment-36010896

@grabbou
Copy link
Member

grabbou commented Nov 24, 2019

Since this is causing issues, I am wondering whether we shouldn't revert #824 entirely and just leave it as it was before?

I believe the amount of regressions is larger than a small number of developers facing issues with a non-standard Gradle project setup (e.g. #804).

We should probably think about it once again and ship a better fix in the next release. I can spend some time on these two this week.

@mrinx
Copy link

mrinx commented Dec 15, 2019

Any news on this one? Currently if I start a fresh project with npx react-native init AwesomeProject on MacOS, npx react-native run-android fails unless I uncomment the dir.

This may cause some frustration to people who are just starting with the framework and have no idea where to look to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants