Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react compiler runtime #1395

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

KaBankz
Copy link
Contributor

@KaBankz KaBankz commented Nov 24, 2024

📝 Why & how

  • Add react-compiler-runtime

Note

I haven't tested the react compiler on any targets besides web and dev clients on ios and android. As such, I've left support for all other targets as false.

✅ Checklist

  • Added library to react-native-libraries.json

Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! 👍

@Simek Simek merged commit 3e0b868 into react-native-community:main Nov 24, 2024
2 checks passed
@KaBankz
Copy link
Contributor Author

KaBankz commented Nov 24, 2024

I just realized that I didn't add "npmPkg": "react-compiler-runtime"

@KaBankz
Copy link
Contributor Author

KaBankz commented Nov 24, 2024

@Simek The pre commit hooks are not letting me set the npmPkg key.

I thought it was necessary in cases like this package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants