-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic New Arch detection and new status #870
Conversation
yeah, we should! we take a different approach to supporting fabric in expo modules and the approach in this pr won't detect it |
this could be useful. if we identify that something is wrong, we can adjust as we go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this meta data!
What do you mean here? Lib maintainer has to manually add this entry in the
Which statuses are you considering? Something like: |
React Native Reanimated also supports the New Architecture but doesn't have any native components or TurboModules, so the possibility to override this flag in |
📝 Why & how
Refs #830
This PR add a basic New Architecture support detection based on the present of the Codegen related field in the library
package.json
.The status in display in the secondary metadata row and links to the New Architecture intro docs on the React Native docs website, which might help the directory users to understand what this term mean, if they sees it in library box.
Things to consider before converting from draft:
📸 Preview
https://react-native-directory-okpe29xli-rndir.vercel.app/
Library Box
✅ Checklist
react-native-libraries.json
react-native-libraries.json