0.59.5 Discussion

[grabbou]

Conversation on this thread are limited to 0.59.5 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

[grabbou]

It's been already requested, please look at my answer here: #113 (comment)

[grabbou]

I am going to cherry-pick React sync commit and do another release, as agreed yesterday. I now got confirmation from the Facebook team that there shouldn't be any problems. I will consider it "working" when all tests pass.

[grabbou]

React sync commit caused regressions that we didn't spot during testing. Note to self: Never cherry-pick React syncs, especially the ones that just landed, as they can cause some issues in production.

0.60.0-rc.0 will be out shortly and that should give you a place to test it.

[matthargett]

Gathered requests from teams that will be on 0.59 for a while that I don't think have been proposed for cherry-pick yet:
facebook/react-native@c36151e
facebook/react-native@e980d83
facebook/react-native@b76acd3
facebook/react-native@1946aee
facebook/react-native@efe6a0f
facebook/react-native@62bac80
facebook/react-native@5e36b0c
facebook/react-native@d99e657
facebook/react-native@9b63b50
facebook/react-native@68a5cee
facebook/react-native@a2b699d
facebook/react-native@c36151e
facebook/react-native@59e5023
facebook/react-native@d5ae59a
facebook/react-native@3711ea6
facebook/react-native@68825f9
facebook/react-native@f541c34
facebook/react-native@972ee2e
facebook/react-native@929908f
facebook/react-native@58c9567
facebook/react-native@c06473a
facebook/react-native@88787b5

[matthargett]

If there's no compatibility problems, this one would also be great to reduce bundle size. We already do this with a patch on top of RN.
facebook/react-native@06cf7fa

[jtreanor]

facebook/react-native@31850df

This is a simple change that fixes several build warnings that have started to appear in Xcode 10.2, particularly when using CocoaPods. It would be great if it could be included in the upcoming version.

[danilobuerger]

Please cherry pick

• [Android] [Fixed] - LayoutAnimations cause invalid view operations facebook/react-native@20b4879

[dulmandakh]

Please cherry pick:

• Fixes Android RTL - facebook/react-native@8d3e168

[thorbenprimke]

Please cherry pick - thanks!

[Android] [Fixed] - The ReactCookieJarContainer/ForwardingCookieHandler now handles the missing WebView gracefully. #24533

[matthargett]

facebook/react-native@c87de76

[Bardiamist]

It should fix letterSpacing of TextInput on iOS.
facebook/react-native@65c014d
Related issue: facebook/react-native#24263
Pull request: facebook/react-native#23738

[estevaolucas]

• Fix accessibility event properties for TextInput facebook/react-native@61c5e35
• Add convert compatible of NSString for bridge message data facebook/react-native@ffa3b0d

[NLthijs48]

It would be nice if this one could get cherry picked:

facebook/react-native@6f6696f [Android] [Fixed] - JS errors during bundle load were reported as UnknownCppException.

(pull request facebook/react-native#24648)

[grabbou]

Cherry-picked everything except for @matthargett commits (yet to go through them and do it) and @Bardiamist (unfortunately, it doesn't merge clearly).

I'll resume tomorrow morning.

Note: The reason it took so long to get to cherry-picking commits to 0.59 was that we were working hard on 0.60. Now that we are partially on hold there, we are back here!

[grabbou]

There were some discussions happening yesterday regarding what we should still cherry pick before releasing this version.

I am waiting to confirm the results of this conversation (timezone differences) and will be back to the release work.

[kelset]

hey everyone, expect a new patch release of RN 0.59 next week-ish. We are still discussing this side of the whole process but we'll keep you updated as we decisions are reached.

[ahce]

@grabbou is safe React Sync for cherry-pick?

[grabbou]

@matthargett, I didn't cherry-pick the following:

• facebook/react-native@5e36b0c (feature request)
• facebook/react-native@d5ae59a (while a fix, it can change a behaviour of Promise.finally)
• facebook/react-native@06cf7fa (similar to the previous one)
• facebook/react-native@1946aee (feature request), facebook/react-native@e980d83 (prop change - breaking patch release)
• two test-related commits

I am happy to discuss this for next patch release if you really need them.

@ahce - React sync cannot be cherry-picked.

[matthargett]

facebook/react-native@28e0de0

Fixed haste for all out of tree platforms

[grabbou]

@matthargett - that one has been cherry-picked. I am now waiting for changelog and this is good to go.

[danilobuerger]

@grabbou Is there a reason why the above mentioned bugfix

[Android] [Fixed] - LayoutAnimations cause invalid view operations facebook/react-native@20b4879

was not cherry picked?

[grabbou]

The commit didn't cherry-pick w/o issues - it has conflicts. Let me move it to 0.59.7 discussion issue and we will do another release.

[kelset]

Closing in favour of #124

[grabbou]

The release hasn't been cut yet due to Detox failure - we are investigating it.