0.61.1 Discussion

[grabbou]

Conversations on this thread are limited to 0.61 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.1 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[xzilja]

When using hooks there seems to be an issue with AppState listeners

useEffect(() => {
    AppState.addEventListener('change', handleStateChange);

    return () => {
      AppState.removeEventListener('change', handleStateChange);
    };
  }, [dynamicValue]);

This now returns

Illegal callback invocation from native module. This callback type only permits a single invocation from native code.

Code wasn't changed on my end, if anyone can think of any commit that could have caused this, I'll be glad to dig in. Also let me know if I should open issue in rn repo for this instead.

[grabbou]

@ScreamZ aware of that and I am investigating the status of this issue. My goal is to release the next minor release with a fix for this.

[ScreamZ]

@grabbou Awesome thanks :)

[grabbou]

After two hours of playing around with it, I have managed to find out that the issue is caused by facebook/react-native@14b455f

I can confirm it renders "just fine" when this commit is reverted. I will now reach out to the authors and other maintainers to see if we can quickly fix the issue or we should revert the commit. Your help is welcome!

I have found the root cause by performing a binary search for a commit that introduced the regression. I think it's a cool approach to debugging, so let me share this with you while we are at it.
Update: You want git-bisect as pointed out by @tido64, thanks!

[tido64]

@grabbou: Git actually has this built in. Have a look at git-bisect 😉

[grabbou]

We will be reverting facebook/react-native@14b455f and doing another release today tomorrow (see for more). I will send appropriate PRs in a second.

[grabbou]

Unfortunately, there was a React Native-wide permission issue which didn't let me push any commit upstream, making it impossible to make a release.

Apologies for those who have been waiting for a release, the issue is now fixed, PRs are being submitted, the release will be out in a matter of hours.

I will keep you updated.

[grabbou]

All commits cherry-picked. Testing them now.

@kristerkari, as pointed out in the first comment in this issue - please point to commits, rather than issues. I do understand this may be causing you and many other people issues, but unless it's a regression, there's nothing we can do here without further debugging.

[grabbou]

Let's continue in #148. The release will be out on npm shortly.

[kristerkari]

as pointed out in the first comment in this issue - please point to commits, rather than issues.

Sorry about that @grabbou . It's just that there is no place where to report bugs that would need a fix + be included in a patch release. The bug reports in facebook/react-native get easily lost with people opening new issues all the time.

[grabbou]

It's all right! I just wanted to explain the fact there's nothing I can do about it "right now". Hoping it can be fixed in the nearest future