Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

V0.63.2 Discussion #200

Closed
grabbou opened this issue Jul 14, 2020 · 13 comments
Closed

V0.63.2 Discussion #200

grabbou opened this issue Jul 14, 2020 · 13 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@grabbou
Copy link
Member

grabbou commented Jul 14, 2020

Conversations on this thread are limited to 0.63 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.63.1 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

@grabbou grabbou added stable Stable version backport request Cherry picking a change into an existing release labels Jul 14, 2020
@mikehardy
Copy link

Campeon @grabbou! This one just landed and makes it so the default new app template doesn't crash everything Android<API21 facebook/react-native@7694b32

@kelset
Copy link
Member

kelset commented Jul 15, 2020

@Bardiamist

This comment has been minimized.

@todorone

This comment has been minimized.

@vikasg603

This comment has been minimized.

@mikehardy
Copy link

This issue is to track cherry-pick requests - a valid request is the commit hash of a change that has landed on master. It is not for tracking open issues.

If you can point to the commit hash in the react-native repo of a landed commit, it can be requested here

@saihaj
Copy link

saihaj commented Jul 16, 2020

Can we do this, it will help fix this -> TypeError: null is not an object (evaluating 'Object.keys(styles[name])')

facebook/react-native@e75557b

@lorenzoangelini

This comment has been minimized.

@kelset
Copy link
Member

kelset commented Jul 16, 2020

@lorenzoangelini as explained by @mikehardy a few comments above:

This issue is to track cherry-pick requests - a valid request is the commit hash of a change that has landed on master. It is not for tracking open issues.

Please open an issue to report the issue in the main repo. This conversation is for requesting commits that can be cherry picked.

@Ashoat
Copy link

Ashoat commented Jul 20, 2020

Can we cherry-pick facebook/react-native@23036b3? This fixes facebook/react-native#29397. tl;dr is that without this, Android apps that specify windowTranslucentNavigation are unable to dismiss LogBox, because the buttons appear below the navigation bar.

@smacgregor
Copy link

Can we cherry pick facebook/react-native@123423c? This fixes showing images on IOS 14.

@djschilling
Copy link

Can we cherry pick facebook/react-native@123423c? This fixes showing images on IOS 14.

That would be great. We are also experiencing this.

@grabbou
Copy link
Member Author

grabbou commented Jul 22, 2020

All commits cherry-picked. No more requests for this release. We're doing tests right now.

@grabbou grabbou closed this as completed Jul 22, 2020
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests