Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][LogBox] Set windowTranslucentNavigation to false #29399

Closed
wants to merge 1 commit into from

Conversation

Ashoat
Copy link
Contributor

@Ashoat Ashoat commented Jul 16, 2020

Summary

This fixes #29397. Without this, apps that specify android:windowTranslucentNavigation draw the LogBox buttons underneath the soft navigation bar, making the buttons unpressable.

Before After

Changelog

[Android] [Fixed] - Set LogBox windowTranslucentNavigation to false

Test Plan

I tested this change on the repo I set up to reproduce the issue. I set it up to build ReactAndroid from source and then edited node_modules/react-native/ReactAndroid/src/main/res/devsupport/values/styles.xml directly.

This fixes facebook#29397. Without this, apps that specify `android:windowTranslucentNavigation` draw the `LogBox` buttons underneath the soft navigation bar, making the buttons unpressable.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2020
@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Jul 16, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,764,121 -2
android hermes armeabi-v7a 6,431,753 12
android hermes x86 7,151,832 15
android hermes x86_64 7,041,840 26
android jsc arm64-v8a 8,935,707 12
android jsc armeabi-v7a 8,595,696 -3
android jsc x86 8,766,519 27
android jsc x86_64 9,342,160 15

Base commit: 6ffb983

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 6ffb983

Ashoat added a commit to CommE2E/comm that referenced this pull request Jul 16, 2020
Error messages end up drawing below the navigation bar, which makes the buttons hard to press.

My PR facebook/react-native#29399 should fix this. We can revert this commit once we upgrade to a version of React Native that has merged that PR
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, importing to land

@Ashoat
Copy link
Contributor Author

Ashoat commented Jul 20, 2020

@mdvacca, I presume something went wrong with the land... is there any way I can help? Failing test cases?

@rickhanlonii
Copy link
Member

Everything looks good, this is landing now.

@Ashoat once this lands, do you want to put a pick request in for 0.63 here: react-native-community/releases#200?

@Ashoat
Copy link
Contributor Author

Ashoat commented Jul 20, 2020

Yeah, will do!

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Ashoat in 23036b3.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 20, 2020
@Ashoat Ashoat deleted the logBoxTranslucentNavFix branch July 20, 2020 17:42
grabbou pushed a commit that referenced this pull request Jul 22, 2020
Summary:
This fixes #29397. Without this, apps that specify `android:windowTranslucentNavigation` draw the `LogBox` buttons underneath the soft navigation bar, making the buttons unpressable.

Before             |  After
:-------------------------:|:-------------------------:
<img src="http://ashoat.com/AndroidTranslucentNavigationLogBox.png" width="300" />  |  <img src="http://ashoat.com/AndroidTranslucentNavigationLogBoxFixed.png" width="300" />

## Changelog

[Android] [Fixed] - Set LogBox windowTranslucentNavigation to false

Pull Request resolved: #29399

Test Plan: I tested this change on the [repo](https://github.com/Ashoat/LogBoxTest) I set up to reproduce the issue. I set it up to [build `ReactAndroid` from source](Ashoat/LogBoxTest@3a2cdab) and then edited `node_modules/react-native/ReactAndroid/src/main/res/devsupport/values/styles.xml` directly.

Reviewed By: rickhanlonii

Differential Revision: D22602970

Pulled By: mdvacca

fbshipit-source-id: 8c2adc149aa0157825075022f00bb695956d3121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android windowTranslucentNavigation makes LogBox buttons unpressable
8 participants