Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cookie belonging to specified url #147

Merged
merged 1 commit into from
May 11, 2022

Conversation

qroll
Copy link
Contributor

@qroll qroll commented Apr 20, 2022

clearByName deletes all cookies with the specified name, even if the cookie's domain does not match the provided url. In fact, the url doesn't seem to be used outside of the initial check that it is valid.

Added a domain match check, based on the behaviour that the requesting domain can set cookies for itself or for a parent domain.

@safaiyeh
Copy link
Member

Much needed change thanks!

@safaiyeh safaiyeh merged commit 9867cbd into react-native-cookies:master May 11, 2022
safaiyeh pushed a commit that referenced this pull request May 11, 2022
## [6.2.1](v6.2.0...v6.2.1) (2022-05-11)

### Bug Fixes

* **Android:** android build error incurred from 6.1.0 ([#149](#149)) ([7d65519](7d65519))
* **iOS:** Clear cookie belonging to specified url ([#147](#147)) ([9867cbd](9867cbd))
@safaiyeh
Copy link
Member

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants