Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a line to the RNDatePickerDialogFragment.java file to stop the library from breaking on android #106

Conversation

kamsy
Copy link

@kamsy kamsy commented Feb 3, 2020

Summary

I installed the library recently for an app I was building and it crashed on Android, read the loads and fixed the bug, so I'm basically creating this PR to help others and myself for a later date when I'd reach for this library

Test Plan

Error:
image

npx react-native run-android

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@vonovak
Copy link
Member

vonovak commented Feb 3, 2020

hi, thanks for the PR. The method should never return null, so used #107 instead

@vonovak vonovak closed this Feb 3, 2020
@kamsy
Copy link
Author

kamsy commented Feb 3, 2020 via email

@vonovak
Copy link
Member

vonovak commented Feb 3, 2020

@kamsy that's odd indeed. Can you share the stacktrace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants