Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on iOS #383

Merged

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Feb 2, 2021

Summary

See issue: #276

Test Plan

  • Open app
  • Open Picker
  • Fast double tap pdf document

Actual: app freezes and/or creashes.

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@vonovak
Copy link
Collaborator

vonovak commented Feb 2, 2021

thanks, I wanted to fix this in a more "structural" way but I guess this will do. Thanks

@vonovak vonovak merged commit 493f9ff into react-native-documents:master Feb 2, 2021
@retyui retyui deleted the fix-crash-when-user-double-tap branch February 3, 2021 09:06
DomiR added a commit to DomiR/react-native-document-picker that referenced this pull request Mar 30, 2021
* upstream/master: (22 commits)
  5.0.2
  fix: copyTo on android to put the file in a uniquely named dir (react-native-documents#397)
  5.0.1
  Fix copyFile on Android. (react-native-documents#392)
  chore: document RN blob support
  5.0.0
  support only android >=5 (API 21) (react-native-documents#386)
  [Android][Google Drive] Download file from google drive then cache in local storage (react-native-documents#264)
  4.3.0
  [Windows] Implementing Folder Picker support (react-native-documents#380)
  Fix crash on iOS (react-native-documents#383)
  chore: deleted duplicate test case (react-native-documents#375)
  chore: change readme wording
  4.2.0
  iOS : add mode option (react-native-documents#345)
  chore: update comment for closing issues (react-native-documents#373)
  chore: update discussions in readme (react-native-documents#372)
  chore: introduce GH discussions (react-native-documents#371)
  chore: add issue actions (react-native-documents#369)
  chore: update provided file type shortcuts
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants