Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use install_modules_dependencies for React iOS dependencies #733

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

oblador
Copy link
Contributor

@oblador oblador commented Aug 22, 2024

Fixes #732

@vonovak vonovak merged commit a17076f into react-native-documents:master Aug 22, 2024
1 check passed
@vonovak
Copy link
Collaborator

vonovak commented Aug 22, 2024

Thank you! 🙂

@vonovak
Copy link
Collaborator

vonovak commented Aug 22, 2024

@oblador just to be sure I understand this, you're saying that with 0.74 when building for old arch, it was enough to depend on 'React-Core' but with 0.75 we need to use install_modules_dependencies to be able to build?

TY :)

@oblador
Copy link
Contributor Author

oblador commented Aug 22, 2024

No, old arch always was fine also on 0.75, but for new arch it didn't work. install_modules_dependencies has been around since 0.71 and will add React-Core for old arch and all the config + deps necessary if new arch is enabled. This is also the best way to support multiple versions as later versions rely on c++20 etc.

@vonovak
Copy link
Collaborator

vonovak commented Aug 22, 2024

ok, good, I thought old arch was affected. TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'rndocumentpicker/rndocumentpicker.h' file not found
2 participants