Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SocialIcon): Add missing apple social icon #3866

Conversation

JaweedVenturedive
Copy link
Contributor

Motivation

On SocialIcon component apple icon is missing, fixed issue by adding support for adding apple social icon.

Fixes #3834

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Existing unit tests pass locally with my changes

Additional context

Before adding apple icon

Screenshot 2023-11-30 at 4 56 15 PM

After adding apple icon

Screenshot 2023-11-30 at 4 56 31 PM

@JaweedVenturedive JaweedVenturedive changed the title fix(SocialIcon): added missing apple social icon fix(SocialIcon): Added missing apple social icon Nov 30, 2023
@arpitBhalla arpitBhalla changed the title fix(SocialIcon): Added missing apple social icon fix(SocialIcon): Add missing apple social icon Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72a4ac5) 79.69% compared to head (0b29dc0) 79.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3866   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files          87       87           
  Lines        1842     1842           
  Branches      811      819    +8     
=======================================
  Hits         1468     1468           
  Misses        369      369           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khushal87 khushal87 merged commit 9b2811c into react-native-elements:next Dec 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SociaIcon: Apple icon is missing
2 participants