feat(android): permit to specify a list of allowed mime-types #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
commented
Jun 16, 2023
| @@ -125,35 +125,42 @@ public void launchImageLibrary(final ReadableMap options, final Callback callbac | |||
| boolean isPhoto = this.options.mediaType.equals(mediaTypePhoto); | |||
| boolean isVideo = this.options.mediaType.equals(mediaTypeVideo); | |||
|
|
|||
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU) { | |||
| boolean usePhotoPicker = Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU; | |||
There was a problem hiding this comment.
I moved this check into a variable as it was used multiple times
renchap
commented
Jun 16, 2023
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU) { | ||
| boolean usePhotoPicker = Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU; | ||
|
|
||
| if (usePhotoPicker) { |
There was a problem hiding this comment.
Order of the statements has been inversed to avoid a negation in the if statement
renchap
commented
Jun 16, 2023
renchap
commented
Jun 16, 2023
renchap
force-pushed
the
restrict-mime-types
branch
from
ac28ad4
to
753a0f4
Compare
|
@Johan-dutoit Could you have a look at this PR? It has been running in our production app for 2 months without issues. |
6 tasks
58 tasks
Bumping this comment |
renchap
force-pushed
the
restrict-mime-types
branch
from
753a0f4
to
55149ba
Compare
renchap
force-pushed
the
restrict-mime-types
branch
from
55149ba
to
a6197d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation (required)
The Android camera app has an option to store both JPEG and RAW (DNG format) files for each picture. When this option is enabled, both versions of the image are shown to the user (but without any indication of the file format, so the users sees every image twice).
This new options allows you to restrict the allowed MIME types, for example
restrictMimeTypes: ['image/jpeg', 'image/heic', 'image/png'].On Android 13 (new Photo Picker), only the matching files are displayed, no more duplicates.
On older Android versions, every file is still displayed in the file explorer, but non-matching files are grayed and can not be selected.
This option can not be implemented on iOS, as the API only allows you to filter on predefined types (images, videos, slow-mos…).
Test Plan (required)
I used
restrictMimeTypes: ['image/jpeg', 'image/heic', 'image/png']with the example app and tested the behaviour with and without the option on an Android 10 and Android 13 devices.