Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README's title usage according to types #804

Merged
merged 1 commit into from
May 10, 2024
Merged

Update README's title usage according to types #804

merged 1 commit into from
May 10, 2024

Conversation

svbutko
Copy link
Contributor

@svbutko svbutko commented May 10, 2024 •
edited
Loading

Overview

Based on TypeScript's types, title is a required field in MenuAction, while README says that its non-required, this PR changes README according to types.

@svbutko svbutko requested a review from Naturalclar as a code owner May 10, 2024 12:01
Naturalclar
Naturalclar approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Naturalclar Naturalclar merged commit ce56137 into react-native-menu:master May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svbutko @Naturalclar