Only execute WifiManager.getConnectionInfo if ACCESS_WIFI_STATE is granted #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The motivation behind this PR is to allow apps to remove ACCESS_WIFI_STATE permission in their app, without the app crashing. We have a case in one of our partner apps where we use netinfo for some network logging, but we don't use all the data collected by netinfo, e.g. wifi data.
We shouldn't crash because of missing permissions, just reduce the data collected.
Test Plan
Before this change:
AndroidManifest.xml in the Android app
logcat:
After this change:
🟢