fix(#310): missing a11y label and hint props on iOS Picker (#582)

react-native-picker · Sep 20, 2024 · ed2c679 · ed2c679
1 parent 95879c2
commit ed2c679
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/ios/RNCPicker.mm b/ios/RNCPicker.mm
@@ -10,7 +10,7 @@
 #import <React/RCTConvert.h>
 #import <React/RCTUtils.h>
 
-@interface RNCPicker() <UIPickerViewDataSource, UIPickerViewDelegate>
+@interface RNCPicker() <UIPickerViewDataSource, UIPickerViewDelegate, UIPickerViewAccessibilityDelegate>
 @end
 
 @implementation RNCPicker
@@ -147,6 +147,19 @@ - (void)pickerView:(__unused UIPickerView *)pickerView
   }
 }
 
+#pragma mark - UIPickerViewAccessibilityDelegate
+
+- (NSString *)pickerView:(UIPickerView *)pickerView accessibilityLabelForComponent:(NSInteger)component
+{
+    return self.accessibilityLabel;
+}
+
+- (NSString *)pickerView:(UIPickerView *)pickerView accessibilityHintForComponent:(NSInteger)component
+{
+    return self.accessibilityHint;
+}
+
+
 #ifdef RCT_NEW_ARCH_ENABLED
 - (void)pickerView:(__unused UIPickerView *)pickerView
       didSelectRow:(NSInteger)row inComponent:(__unused NSInteger)component

diff --git a/js/PickerIOS.ios.js b/js/PickerIOS.ios.js
@@ -113,6 +113,8 @@ const PickerIOSWithForwardedRef: React.AbstractComponent<
     onChange,
     onValueChange,
     style,
+    accessibilityLabel,
+    accessibilityHint,
   } = props;
 
   const nativePickerRef = React.useRef<React.ElementRef<
@@ -199,6 +201,8 @@ const PickerIOSWithForwardedRef: React.AbstractComponent<
         ref={ref}
         themeVariant={themeVariant}
         testID={testID}
+        accessibilityLabel={accessibilityLabel}
+        accessibilityHint={accessibilityHint}
         style={[styles.pickerIOS, itemStyle]}
         // $FlowFixMe
         items={items}