Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneccessaries from pch to reduce size and fix storage quota issues in build #254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

burtonrodman
Copy link

significant reduction in size of PCH by removing unnecessary includes

@NickGerleman
Copy link
Contributor

Lgtm assuming this still builds after removal.

@asklar
Copy link

asklar commented May 19, 2021

this will reduce the pch size (known to be large) at the expense of slower builds (recompiling the same headers everywhere they are used), which for xaml headers can be significant.

@burtonrodman
Copy link
Author

agreed. but if it doesn’t build at all because it generates a gig of pch and exceeds the build agent storage quota, then that perf gain is a detriment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants