Fix for #119 #221
Merged
Fix for #119 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved docs and added example for notification with custom sound.
Naturalclar
reviewed
Oct 29, 2020
Naturalclar
requested changes
Oct 29, 2020
There was a problem hiding this comment.
@alexnaiman This is awesome! thank you so much.
Could I ask you to use addRequestNotification instead of presentLocalNotification? Thanks!
|
@Naturalclar Done! 😄 It will be very nice if it could be accepted for this hacktoberfest. I think it should be either merged, approved or one maintainer should add the Thanks a lot! |
Naturalclar
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
@alexnaiman thank you so much! Verified that it's working properly 👍
Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #119
Improved docs and added example for notification with custom sound.