-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion handler is not called #311
Completion handler is not called #311
Conversation
Looks great. I think the example project needs to be updated as well 👍🏼 |
@leethree I updated the example project and rebased my PR. I still need to re-confirm that this is functioning properly before it gets merged since there seem to have been quite a few other commits since I opened this. |
This is still an issue -- any updates on when this can get reviewed and merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@chrisbobbe @Naturalclar I think we need to be clear about the responsibilities of this library. |
The provided
completionHandler
is being saved to theremoteNotificationCallbacks
dictionary, but the nativeonFinishRemoteNotification:(NSString *)notificationId fetchResult:(UIBackgroundFetchResult)result
function didn't actually lookup and call the completion handler.I believe this fixes that bug and addresses #216 #244 #297 as well.