Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow to use PlatformColor in the theme colors #11495

Closed
wants to merge 2 commits into from

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Jul 25, 2023

@github-actions
Copy link

Hey @retyui! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit 24d1a0b
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/64f05c3ca27eed0008d1f54f
😎 Deploy Preview https://deploy-preview-11495--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (ba53154) 75.49% compared to head (24d1a0b) 75.49%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11495   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files         190      190           
  Lines        5742     5742           
  Branches     2261     2261           
=======================================
  Hits         4335     4335           
  Misses       1360     1360           
  Partials       47       47           
Files Changed Coverage Δ
packages/bottom-tabs/src/views/BottomTabItem.tsx 63.46% <ø> (ø)
packages/bottom-tabs/src/views/TabBarIcon.tsx 100.00% <ø> (ø)
packages/drawer/src/views/DrawerItem.tsx 62.85% <ø> (ø)
packages/elements/src/Header/HeaderTitle.tsx 100.00% <ø> (ø)
packages/elements/src/MissingIcon.tsx 100.00% <ø> (ø)
packages/native-stack/src/views/HeaderConfig.tsx 63.46% <ø> (ø)
packages/react-native-tab-view/src/TabBar.tsx 58.54% <ø> (ø)
packages/react-native-tab-view/src/TabBarItem.tsx 81.33% <0.00%> (ø)
...ages/react-native-tab-view/src/TabBarItemLabel.tsx 28.57% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@retyui retyui closed this Aug 31, 2023
@retyui retyui deleted the fix-11481 branch August 31, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Error: Type 'OpaqueColorValue' is not assignable to type 'string' when I use PlatformColor
2 participants