Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Android): added navigationBarTranslucent option #11998

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat(Android): added navigationBarTranslucent option #11998

merged 3 commits into from
Jun 20, 2024

Conversation

alduzy
Copy link
Contributor

@alduzy alduzy commented May 21, 2024

Motivation

This PR intents to enable navigation bar translucency control. You can find more about this feature here

Test plan

Play around with following screen options:

  <Stack.Navigator
    screenOptions={{
      navigationBarColor: 'transparent',
      navigationBarTranslucent: true,
      navigationBarHidden: false,
    }}>

Copy link

Hey @alduzy! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit 713af9b
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/66743f09bafeaf000811f6c7
😎 Deploy Preview https://deploy-preview-11998--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@satya164 satya164 enabled auto-merge (squash) June 20, 2024 14:37
@satya164 satya164 disabled auto-merge June 20, 2024 14:38
@satya164 satya164 enabled auto-merge (squash) June 20, 2024 14:38
@satya164 satya164 merged commit 2864b6c into react-navigation:main Jun 20, 2024
8 checks passed
@alduzy alduzy deleted the @alduzy/navigation-bar-translucent branch June 20, 2024 15:24
@jvgeee
Copy link

jvgeee commented Sep 2, 2024

@alduzy @satya164 is this feature available on v6.11.x? I'm not seeing navigationBarTranslucent as an available in screenOptions (or anywhere else)

Copy link

github-actions bot commented Sep 2, 2024

Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro.

@linnett
Copy link

linnett commented Sep 5, 2024

@jvgeee I would also like to know the answer to this. @alduzy @satya164

@alduzy
Copy link
Contributor Author

alduzy commented Sep 5, 2024

@linnett @jvgeee It's available from v7 (

# [7.0.0-rc.0](https://github.com/react-navigation/react-navigation/compare/@react-navigation/native-stack@7.0.0-alpha.20...@react-navigation/native-stack@7.0.0-rc.0) (2024-06-27)
)

@linnett
Copy link

linnett commented Sep 5, 2024

@alduzy Damn... Please can you recommend a way to fix this on 6.* , given this is a bug? I can't upgrade to a pre-release.

@alduzy
Copy link
Contributor Author

alduzy commented Sep 6, 2024

@linnett you can apply the changes with a patch. Please note that you must be using react-native-screens v3.32.0 or newer for it to work. @satya164 Are you planning to bring this feature to v6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants