fix: change single param to props object in onTransition callba… (fac…

…ebook#171)
react-one · Aug 18, 2019 · 53f8ba9 · 53f8ba9
1 parent c0c17e9
commit 53f8ba9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/stack/src/types.tsx b/packages/stack/src/types.tsx
@@ -93,6 +93,10 @@ export type HeaderProps = {
   styleInterpolator: HeaderStyleInterpolator;
 };
 
+export type TransitionCallbackProps = {
+  closing: boolean;
+};
+
 export type NavigationStackOptions = HeaderOptions &
   Partial<TransitionPreset> & {
     title?: string;
@@ -107,8 +111,8 @@ export type NavigationStackOptions = HeaderOptions &
       vertical?: number;
       horizontal?: number;
     };
-    onTransitionStart?: (closing: boolean) => void;
-    onTransitionEnd?: (closing: boolean) => void;
+    onTransitionStart?: (props: TransitionCallbackProps) => void;
+    onTransitionEnd?: (props: TransitionCallbackProps) => void;
   };
 
 export type NavigationStackConfig = {

diff --git a/packages/stack/src/views/Stack/Stack.tsx b/packages/stack/src/views/Stack/Stack.tsx
@@ -263,7 +263,7 @@ export default class Stack extends React.Component<Props, State> {
 
     descriptor &&
       descriptor.options.onTransitionStart &&
-      descriptor.options.onTransitionStart(closing);
+      descriptor.options.onTransitionStart({ closing });
   };
 
   private handleTransitionEnd = (
@@ -274,7 +274,7 @@ export default class Stack extends React.Component<Props, State> {
 
     descriptor &&
       descriptor.options.onTransitionEnd &&
-      descriptor.options.onTransitionEnd(closing);
+      descriptor.options.onTransitionEnd({ closing });
   };
 
   render() {