Move 'this' binding to componentWillMount #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanpodila
reviewed
Oct 12, 2016
| @@ -12,6 +12,13 @@ export default class Rule extends React.Component { | |||
| }; | |||
| } | |||
|
|
|||
| componentWillMount() { | |||
| this.onFieldChanged = this.onFieldChanged.bind(this); | |||
There was a problem hiding this comment.
Instead of doing any .bind(), we could also just do this:
onFieldChanged = ()=>{ /* ... */};this relies on the property-initializer syntax. Note that we have to include this babel-plugin
npm install --save-dev babel-preset-stage-1
maniax89
force-pushed
the
binding_methods
branch
from
f8d983c to
3568f3d
Compare
pavanpodila
approved these changes
Oct 12, 2016
|
@maniax89 Seeing test failures after the merge. Possibly because of plugin issues or webpack.test is not configured correctly ? |
jakeboone02
added a commit
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding of methods should be done during the creation of the object not during the creation of the children components