Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule group tests #13

Merged
merged 2 commits into from
Oct 12, 2016
Merged

Conversation

maniax89
Copy link
Contributor

Adds code coverage in for the component

@pavanpodila pavanpodila merged commit 84f0b73 into react-querybuilder:master Oct 12, 2016
@pavanpodila
Copy link
Contributor

pavanpodila commented Oct 12, 2016

Also I would prefer to keep the tests next to the source files. Right now we have it in a separate test folder. Would you be ok moving them inside lib and rename them to *.test.js ?

With that the file glob in karma gets simplified as well

@pavanpodila
Copy link
Contributor

Fixed this by also adding babel-preset-es2015. There is still a failing test:

<Rule />
    onValueChanged
      ✖ should call the onPropChange with the rule id
        PhantomJS 2.1.1 (Mac OS X 0.0.0)
      expected 'value' to equal 'any_field'

@maniax89
Copy link
Contributor Author

sure i can move them back to with the source files. I've seen it done both ways (i've just come from a background where they are separate).

I'll take a look at that test failure. I typically try to do rm -rf node_modules then npm install then npm test to see if my changes are working but maybe that's not catching everything

@maniax89 maniax89 deleted the rule_group_tests branch October 12, 2016 21:45
jakeboone02 added a commit that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants