-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio Button is broken with RHL #1368
Comments
Hi, |
I updated to |
you are able to check the radios? |
code cools like this:
|
This was done due to the bugs on the onChange events. See react-toolbox/react-toolbox#1368 and react-toolbox/react-toolbox#1417 for more details.
* Downgraded react packages due to toolbox dependencies * Replaced custom components with toolbox components * Minor text edit * Renamed component ScientistAdd to ScientistForm * Fixed dependencies issues for react-toolbox * Bypass react-toolbox RadioButton and RadioGroup This was done due to the bugs on the onChange events. See react-toolbox/react-toolbox#1368 and react-toolbox/react-toolbox#1417 for more details. * Updated example app functionality
Having this issue with beta.12 and rhl 4.0.0. Is there any solution? edit: actually, it's unrelated to rhl. Radio groups fail even w/o rhl. RadioButton and child.type are both ThemedRadioButton, but they compare not equal, so props are not propagated to the child. |
I'm experiencing an issue with
RadioGroup
andreact-hot-loader
together.isComponentOfType is overwritten in my case. If I remove RHL, it works.
this is caused by the fact, that
isComponentOfType
inRadioGroup
is loaded fromutils/react
instead ofutils/is-component-of-type
and is not overwritable.The text was updated successfully, but these errors were encountered: