Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Theme section proposal #964

Closed
przemyslaw-wlodek opened this issue Nov 15, 2016 · 4 comments
Closed

Docs Theme section proposal #964

przemyslaw-wlodek opened this issue Nov 15, 2016 · 4 comments

Comments

@przemyslaw-wlodek
Copy link

przemyslaw-wlodek commented Nov 15, 2016

Hello,

--- ORIGINAL QUESTION
I've noticed that DatePicker theme table is missing label property.

--- EDIT
Sorry if it's non issue, I've just found that Feel free to take a look into the original themes or just check the selectors you want to override in DevTools.

Could you please add this kind of information at the bottom of docs (under theme)?
It would be nice to see this if someone's just reading any component doc, not just a theming section.

Something like If any property is missing you can check the selectors you want to override in DevTools..

P.S. Thank you for your hard work. This project is really great.

@przemyslaw-wlodek przemyslaw-wlodek changed the title DatePicker - missing theme property 'label' Docs Theme section proposal Nov 15, 2016
@borela
Copy link
Contributor

borela commented Nov 22, 2016

@javivelasco It would be interesting to open source the website to enable people to fix the documentation faster.

@rubenmoya
Copy link
Collaborator

@borela It's already open sourced, you just have to edit the README.md of the component

@borela
Copy link
Contributor

borela commented Nov 22, 2016

@rubenmoya Nice, didn't notice that, my bad.

@javivelasco
Copy link
Member

Thank you @xgarrett !

alexi21 added a commit to EventHubAU/react-toolbox that referenced this issue Dec 6, 2016
* dev: (285 commits)
  Fixes react-toolbox#1016
  Enable theming of Input component inside Dropdown component. Related to react-toolbox#877 and react-toolbox#920 and commit #d0a9032
  Make Tooltip use currentTarget instead of target when calculating the position
  Allow Tooltip factory to use string native components
  Make chips avatar detection work when decorated
  Release 1.3.1
  Fixes react-toolbox#1007
  Fixes react-toolbox#1001
  Dropdown auto fix
  Fixes react-toolbox#236
  Fixes react-toolbox#964
  Fixes react-toolbox#999
  Release 1.3.0
  Add tooltipShowOnClick to README
  add required attribute to DropdownProps interface
  Extend extensions
  Pass event to selection.
  Fix react-toolbox#939
  Fix react-toolbox#409
  Fix react-toolbox#953
  ...

# Conflicts:
#	components/autocomplete/Autocomplete.js
#	lib/autocomplete/Autocomplete.js
#	lib/button/Button.js
#	lib/button/IconButton.js
#	lib/checkbox/Checkbox.js
#	lib/date_picker/Calendar.js
#	lib/date_picker/CalendarDay.js
#	lib/date_picker/CalendarMonth.js
#	lib/date_picker/DatePicker.js
#	lib/date_picker/DatePickerDialog.js
#	lib/dropdown/Dropdown.js
#	lib/form/Form.js
#	lib/hoc/ActivableRenderer.js
#	lib/hoc/Portal.js
#	lib/input/Input.js
#	lib/list/List.js
#	lib/list/ListItem.js
#	lib/list/ListItemContent.js
#	lib/menu/IconMenu.js
#	lib/menu/Menu.js
#	lib/menu/MenuItem.js
#	lib/overlay/Overlay.js
#	lib/progress_bar/ProgressBar.js
#	lib/radio/RadioButton.js
#	lib/radio/RadioGroup.js
#	lib/ripple/Ripple.js
#	lib/slider/Slider.js
#	lib/snackbar/Snackbar.js
#	lib/switch/Switch.js
#	lib/table/Table.js
#	lib/table/TableRow.js
#	lib/tabs/Tab.js
#	lib/tabs/TabContent.js
#	lib/tabs/Tabs.js
#	lib/tabs/__tests__/index.spec.js
#	lib/time_picker/Clock.js
#	lib/time_picker/ClockFace.js
#	lib/time_picker/ClockHand.js
#	lib/time_picker/ClockHours.js
#	lib/time_picker/ClockMinutes.js
#	lib/time_picker/TimePicker.js
#	lib/time_picker/TimePickerDialog.js
#	lib/tooltip/Tooltip.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants