Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled components v5 #184

Closed
wants to merge 1 commit into from
Closed

Styled components v5 #184

wants to merge 1 commit into from

Conversation

maxquinn
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arturbien/react95/f233m3wv2
✅ Preview: https://react95-git-fork-maxquinn-upgrade-styled-components-v5.arturbien.vercel.app

Comment on lines +18 to +21
"presets": ["@babel/preset-env"],
"plugins": [
["babel-plugin-styled-components", { "ssr": false, "displayName": false }]
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add this because of an issue with jest-styled-components. See here: styled-components/jest-styled-components#294

@arturbien
Copy link
Member

@maxquinn thanks for your PR! 💗 everything seems to look fine, but we need to change the commit message since we're using standarized commit messages. instead of running git commit ... run git cz and follow instructions in the terminal

@maxquinn maxquinn closed this Aug 31, 2020
@maxquinn maxquinn deleted the upgrade/styled-components-v5 branch August 31, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants