Fix webhooks for users with no avatars (#530)

* Consistently use this.bot in tests Some tests were subtly testing broken behavior, as this.addUser was not correctly adding a user to the given bot's guild. * Group up webhook tests in contexts * Fix webhooks for users with no avatars Fixes #529.
reactiflux · Jan 4, 2020 · 4fe1483 · 4fe1483
1 parent 88fecf3
commit 4fe1483
Show file tree

Hide file tree

Showing 2 changed files with 184 additions and 174 deletions.
diff --git a/lib/bot.js b/lib/bot.js
@@ -438,7 +438,8 @@ class Bot {
 
     // No matching user or more than one => default avatar
     if (users && users.size === 1) {
-      return users.first().user.avatarURL.replace(/\?size=\d{1,}$/, '?size=128');
+      const url = users.first().user.avatarURL;
+      if (url) return url.replace(/\?size=\d{1,}$/, '?size=128');
     }
 
     // If there isn't a URL format, don't send an avatar at all