Fix ircStatusNotices when channels are not lowercase #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix reactiflux#216, by lowercasing the channel name when it receives each event. This also adds debug messages to make it easier to see when the bot is actually receiving (and presumably processing) these events.
ekmartin
approved these changes
Apr 14, 2017
|
Good catch - thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #216, by lowercasing the channel name when it receives each event. This also adds debug messages to make it easier to see when the bot is actually receiving (and presumably processing) these events.
(When I tested it with the #NovaMC channel, it did in fact crash on master but did not on this branch.)
The added tests fail on master – the first, obviously, because master is not trying to lowercase the channel name, and the second reproduces this particular example with fake events, demonstrating the actual failure of the old code.
It may still be useful to merge #218, in case there are other circumstances that could produce this (such as a race condition for the events, which I think is possible though maybe not likely).